| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Date: | 2022-02-12 22:10:32 |
| Message-ID: | CA+Tgmobva6NRLtp=8z3V8EzmwryOdfZwBy+8NUf8aQH5B9p-1A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Feb 12, 2022 at 5:09 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2022-02-12 07:24:46 -0500, Robert Haas wrote:
> > You may be right, but I'm not entirely convinced. $ENV{'LZ4'} here is
> > being set by make, and make is setting it to whatever configure found.
> > If configure found a version of the lz4 program that doesn't actually
> > work, isn't that configure's fault, or the system administrator's
> > fault, rather than this test's fault?
>
> I don't think there's an actual configure check for the lz4 binary? Looks like
> a static assignment in src/Makefile.global.in to me.
Oh. That seems kind of dumb.
It does mean that trying to run it is all that we can do, though,
because we don't have a full path.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-02-12 22:16:03 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Previous Message | Andres Freund | 2022-02-12 22:09:13 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-02-12 22:16:03 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Previous Message | Andres Freund | 2022-02-12 22:09:13 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |