Re: Wrong assert in TransactionGroupUpdateXidStatus

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Wrong assert in TransactionGroupUpdateXidStatus
Date: 2019-12-15 03:21:08
Message-ID: CA+TgmobvOCr4xD=dRQTSSj4qXDQkgvxGhuSeATcG4YNXzh4Lsw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 12, 2019 at 9:23 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Do you think we need such an Assert after having StaticAssert for
> (THRESHOLD_SUBTRANS_CLOG_OPT <= PGPROC_MAX_CACHED_SUBXIDS) and then
> an if statement containing (nsubxids <= THRESHOLD_SUBTRANS_CLOG_OPT)
> just before this Assert? Sure, we can keep this for extra safety, but
> I don't see the need for it.

I don't have strong feelings about it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-12-15 03:24:35 Re: allowing broader use of simplehash
Previous Message Justin Pryzby 2019-12-14 22:47:35 Re: pg_ls_tmpdir to show shared filesets