Re: Use get_call_result_type() more widely

On Mon, Dec 19, 2022 at 2:07 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> On the other hand, the measurements have shown that going through the
> function is significantly slower. So I kinda like the judgement call
> that Michael and Bharath have made: change to use the function when
> performance is not an issue, and keep the verbose coding otherwise.

Seems fairly arbitrary to me. The ones used for monitoring queries
aren't likely to be run often enough that it matters, but in theory
it's possible that they could be. Many of the ones supposedly not used
for monitoring queries could reasonably be so used, too. You can get
any answer you want by making arbitrary assumptions about which ones
are likely to be used frequently and how frequently they're likely to
be used, and I think different people evaluating the list
independently of each other and with no knowledge of each others work
would likely reach substantially different conclusions, ranging all
the way from "do them all this way" to "do them all the other way" and
various positions in the middle.

--
Robert Haas
EDB: http://www.enterprisedb.com