From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Subject: | Re: [COMMITTERS] pgsql: Implement table partitioning. |
Date: | 2017-10-13 19:30:57 |
Message-ID: | CA+Tgmobv=Vd-EbPcXAqvJG3r_gnNPPR2DMqSq3ZVMvggLWy_bg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Oct 13, 2017 at 12:34 PM, Alvaro Herrera
<alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Robert Haas wrote:
>> Implement table partitioning.
>
>> Currently, tables can be range-partitioned or list-partitioned. List
>> partitioning is limited to a single column, but range partitioning can
>> involve multiple columns. A partitioning "column" can be an
>> expression.
>
> I find the "partition strategy" thing a bit suspect code-wise. I was a
> bit bothered by all the "default:" clauses in switches that deal with
> the possible values, and I was going to propose simply that we turn that
> into an enum -- a trivial patch, I thought. Not so: the way it's used
> by the grammar is a bit odd. Apparently, it starts life as a string
> (either "list" or "range"), and then transformPartitionSpec() has to go
> out of its way to return it as a char.
>
> I propose we have gram.y itself resolve the strings to either 'list' or
> 'range' and that the node contains only those values, not any string.
> Unless there is a reason why things are like this that I'm not seeing?
I don't think I feel strongly about this, but I'm also not sure
exactly what problem you are trying to solve. Do you want to
elaborate on that a bit?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-10-13 21:29:03 | pgsql: Improve sys/catcache performance. |
Previous Message | Andres Freund | 2017-10-13 19:15:52 | pgsql: Force "restrict" not to be used when compiling with xlc. |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-10-13 19:32:01 | Re: relkind check in DefineIndex |
Previous Message | Robert Haas | 2017-10-13 19:09:30 | Re: Parallel Bitmap Heap Scans segfaults due to (tbm->dsa==NULL) on PostgreSQL 10 |