| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Vaishnavi Prabakaran <vaishnaviprabakaran(at)gmail(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactor handling of database attributes between pg_dump and pg_dumpall |
| Date: | 2017-09-29 17:31:16 |
| Message-ID: | CA+TgmobssnxStfgwTrV6fv=rbSmT1v0jd+DMLKqBqJuCtMtZLA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 29, 2017 at 12:44 AM, Vaishnavi Prabakaran
<vaishnaviprabakaran(at)gmail(dot)com> wrote:
> Option name "--enable-pgdumpall-behaviour" is very generic
Yeah, that's a terrible name, at least in my opinion.
> and it is better
> to rename it to something that reflects its functionality like
> --skip-default-db-create/--no-default-db-create
But I wonder why this patch needs a new option at all?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-09-29 17:43:22 | Re: Bug with pg_basebackup and 'shared' tablespace |
| Previous Message | Robert Haas | 2017-09-29 17:29:04 | Re: A design for amcheck heapam verification |