Re: pg_amcheck contrib application

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_amcheck contrib application
Date: 2021-03-12 13:33:14
Message-ID: CA+TgmobrSJCx3PgUAYqOcqDjAN+SCjOJfJ6umGgkpp9sqQauSQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 12, 2021 at 12:00 AM Mark Dilger
<mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> Your proposal is used in this next version of the patch, along with a resolution to the solution to the -D option handling, discussed before, and a change to make --schema and --exclude-schema options accept "database.schema" patterns as well as "schema" patterns. It previously only interpreted the parameter as a schema without treating embedded dots as separators, but that seems strangely inconsistent with the way all the other pattern options work, so I made it consistent. (I think the previous behavior was defensible, but harder to explain and perhaps less intuitive.)

Well, OK. In that case I guess we need to patch the docs a little
more. Here's a patch documentation that revised behavior, and also
tidying up a few other things I noticed along the way.

Since nobody is saying we *shouldn't* move this to src/bin, I think
you may as well go put it there per Peter's suggestion.

Then I think it's time to get this committed and move on to the next thing.

--
Robert Haas
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
more-doc-hacking.patch application/octet-stream 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-03-12 14:33:05 Re: shared-memory based stats collector
Previous Message Amit Khandekar 2021-03-12 13:14:13 Re: [POC] verifying UTF-8 using SIMD instructions