From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Satoshi Nagayasu <snaga(at)uptime(dot)jp> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, satoshi(dot)nagayasu(at)gmail(dot)com |
Subject: | Re: [PATCH] XLogReader v2 |
Date: | 2012-07-23 17:27:08 |
Message-ID: | CA+TgmobqiQ_d1AzfjtJoLVGrqEMKWVTkUEUm7yO5LbZsXFFzUA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jul 23, 2012 at 1:03 PM, Satoshi Nagayasu <snaga(at)uptime(dot)jp> wrote:
>> The stringinfo thing has long been an annoyance to me. libpq has
>> PQExpBuffer which is the exact same thing. I don't like that we have
>> two implementations of that in two different code bases, and you have
>> to remember to spell it right depending on where you are. I'm not
>> sure exactly what the best way to fix that is, but it sure is a pain
>> in the neck.
>
> Does it make sense to make some static library which can be
> referred from both the backend and several client utilities,
> including libpq? Or just a dynamic link be preferred?
>
> Despite I do not have a clear idea right now, is it time to
> start thinking of it?
IMHO, yes. I'm not sure exactly what the right way to do it is, but I
think we need something along these lines. We've got some pg_dump
code - in dumputils.c - that is also linked into other applications
such as psql, too, which is another pile of grottiness for which we
need a better solution.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Manoj Govindassamy | 2012-07-23 17:54:36 | Re: Pg_ctl promote -- wait for slave to be promoted fully ? |
Previous Message | Satoshi Nagayasu | 2012-07-23 17:03:11 | Re: [PATCH] XLogReader v2 |