| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A Typo in regress/sql/privileges.sql |
| Date: | 2015-12-18 18:50:34 |
| Message-ID: | CA+Tgmobq7GT=DdPxYb0tSHkyY2zVfWZxPrRLiG35MH=abjG5aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 16, 2015 at 11:51 PM, Tatsuro Yamada
<yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> I found typos in privileges.sql and privileges.out
> Please find attached a patch.
Thanks, good catch. But even aside from this particular issue, isn't
that comment in need of a little more love? An inference means a
deduction, or something you can figure out from something else. ON
CONFLICT (four) is not an inference. Why don't we say:
-- Check that the columns in the ON CONFLICT clause require select privileges
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-12-18 18:55:21 | Re: Using quicksort for every external sort run |
| Previous Message | Tom Lane | 2015-12-18 18:39:01 | Re: Patch: ResourceOwner optimization for tables with many partitions |