From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Tomáš Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: extend pgbench expressions with functions |
Date: | 2015-12-18 18:32:23 |
Message-ID: | CA+Tgmobpv4S=33Q9TDhX_OUJAfGHMzrpZ=iB_U=1+Nj11=hYSA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Dec 16, 2015 at 12:54 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Dec 16, 2015 at 6:10 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Dec 14, 2015 at 7:25 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> I have looked for now at the first patch and finished with the
>>> attached while looking at it. Perhaps a committer could look already
>>> at that?
>>
>> It looks fine to me except that I think we should spell out "param" as
>> "parameter" throughout, instead of abbreviating.
>
> Fine for me. I have updated the first patch as attached (still looking
> at the second).
Committed. I was on the fence about whether to back-patch this
considering how close we are to release, but ended up deciding to go
for it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-12-18 18:39:01 | Re: Parallel Aggregate |
Previous Message | Robert Haas | 2015-12-18 18:16:50 | Re: Additional LWLOCK_STATS statistics |