| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: backup manifests |
| Date: | 2020-04-02 18:55:19 |
| Message-ID: | CA+TgmoboTL8cBt_P5Jx6RjL=Hk3Y8PbpGsh9KcH_MZuswVqdYA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 2, 2020 at 2:23 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > That might make the window fairly wide on normal systems, but I'm not
> > sure about Raspberry Pi BF members or things running
> > CLOBBER_CACHE_ALWAYS/RECURSIVELY. I guess I could try it.
>
> You can set checkpoint_timeout to be a day. If that's not enough, well,
> then I think we have other problems.
I'm not sure that's the only issue here, but I'll try it.
> Yes, I am asking for something to be changed: I'd like the code that
> read()s the file when computing the checksum to add up how many bytes
> were read, and compare that to the size in the manifest. And if there's
> a difference report an error about that, instead of a checksum failure.
>
> I've repeatedly seen filesystem issues lead to to earlier EOFs when
> read()ing than what stat() returns. It'll be pretty annoying to have to
> debug a general "checksum failure", rather than just knowing that
> reading stopped after 100MB of 1GB.
Is 0004 attached like what you have in mind?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| v19-0001-pg_waldump-Add-quiet-option.patch | application/octet-stream | 4.0 KB |
| v19-0004-Recheck-file-size-at-checksum-time.patch | application/octet-stream | 2.0 KB |
| v19-0002-Add-checksum-helper-functions.patch | application/octet-stream | 9.5 KB |
| v19-0003-Generate-backup-manifests-for-base-backups-and-v.patch | application/octet-stream | 137.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-04-02 19:02:55 | Re: backup manifests |
| Previous Message | Tom Lane | 2020-04-02 18:51:59 | Re: control max length of parameter values logged |