| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2021-10-25 20:15:24 |
| Message-ID: | CA+TgmobnZT4JKVNfAhWru951HA8P7SBNdCbJvCxAXu0=2+6WdA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 15, 2021 at 8:05 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > You mean the way gzip allows us to use our own alloc and free functions
> > by means of providing the function pointers for them. Unfortunately,
> > no, LZ4 does not have that kind of provision. Maybe that makes a
> > good proposal for LZ4 library ;-).
> > I cannot think of another solution to it right away.
>
> OK. Will give it some thought.
Here's a new patch set. I've tried adding a "cleanup" callback to the
bbsink method and ensuring that it gets called even in case of an
error. The code for that is untested since I have no use for it with
the existing basebackup sink types, so let me know how it goes when
you try to use it for LZ4.
I've also added documentation for the new pg_basebackup options in
this version, and I fixed up a couple of these patches to be
pgindent-clean when they previously were not.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Introduce-bbsink-abstraction-to-modularize-base-b.patch | application/octet-stream | 78.0 KB |
| v8-0003-Modify-pg_basebackup-to-use-a-new-COPY-subprotoco.patch | application/octet-stream | 33.7 KB |
| v8-0002-Introduce-bbstreamer-abstraction-to-modularize-pg.patch | application/octet-stream | 80.3 KB |
| v8-0004-Support-base-backup-targets.patch | application/octet-stream | 34.2 KB |
| v8-0005-Server-side-gzip-compression.patch | application/octet-stream | 21.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-10-25 20:29:04 | Re: parallelizing the archiver |
| Previous Message | Bruce Momjian | 2021-10-25 20:06:50 | Re: XTS cipher mode for cluster file encryption |