Re: [HACKERS] Proposal: Local indexes for partitioned table

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Maksim Milyutin <milyutinma(at)gmail(dot)com>
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
Date: 2017-12-18 16:08:15
Message-ID: CA+Tgmobm6_3xzW4KL9Z1J3FwzYCAfVChgo=CCcVQGnjgunnmPw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 18, 2017 at 11:02 AM, Alvaro Herrera
<alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> After this discussion, this is how I see things working:
>
> 1. pg_dump
> a) creates indexes on partitions normally
> b) once all existing indexes are done, index on parent is created,
> with ONLY. No cascading occurs, no indexes are attached.
> c) ATTACH is run for each existing partition index. After each
> ATTACH, we check that all indexes exist. If so, the parent is
> marked valid.
> d) if not all indexes existed in partitions, index on parent remains
> invalid. (It was invalid in the dumped database, so this is
> correct.)
>
> 2. other uses
> Normal CREATE INDEX (without ONLY) recurses and attaches the first
> matching index it finds (no duplicate indexes are created);
> partitions without a matching index get one created.
>
> 3. ALTER INDEX DETACH is not provided. Therefore: once index is valid,
> it remains so forever.
>
> I think this satisfies all concerns.

Sounds great to me.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-12-18 16:12:34 Re: [HACKERS] Custom compression methods
Previous Message Alvaro Herrera 2017-12-18 16:02:30 Re: [HACKERS] Proposal: Local indexes for partitioned table