| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: rewrite ExecPartitionCheckEmitError |
| Date: | 2018-12-07 20:32:32 |
| Message-ID: | CA+TgmobkopYEY3nwjuCBWyWe3ADd1QDkGz0EB1suagXN_qQSUw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 6, 2018 at 5:22 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Just on cleanliness grounds, I propose to rewrite the function in
> $SUBJECT. I came across this while reviewing some already-committed
> patch for partition pruning, and it's been sitting in my laptop ever
> since.
>
> I think the current coding is too convoluted and hard to follow. The
> patch makes it much simpler (IMO).
I don't really think this is an improvement, but the only part I
really dislike is s/val_desc/valdsc/. That is surely not an
improvement in readability.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-12-07 20:34:39 | Re: Statement-level rollback |
| Previous Message | Robert Haas | 2018-12-07 20:28:09 | Re: proposal: plpgsql pragma statement |