| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan) |
| Date: | 2016-06-09 03:17:18 |
| Message-ID: | CA+TgmobkHnBoiojSVpu9Fw+m-Zs=DiEMc9cV=J4E2vY_h5dj7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 6, 2016 at 6:07 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> That seems doable, as for such rels we can only have Vars and
> PlaceHolderVars in targetlist. Basically, whenever we are adding
> PlaceHolderVars to a relation, just remember that information and use it
> later. The patch doing the same is attached with this mail. Now still,
> this won't cover the case of ChildRels for an Append Relation as for that we
> adjust target list separately in set_append_rel_size. I think we need to
> deal with it separately.
This approach looks pretty good to me. Here's a revised version of
your patch, with some renaming and other adjustments. I'm not sure
exactly what you're referring to in set_append_rel_size, but I did add
a line of code there that might be relevant.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| check-tlists-rmh.patch | binary/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-06-09 03:18:24 | Re: Reviewing freeze map code |
| Previous Message | Tatsuro Yamada | 2016-06-09 03:08:01 | Re: ORDER/GROUP BY expression not found in targetlist |