| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix double-release of spinlock |
| Date: | 2024-07-29 17:37:52 |
| Message-ID: | CA+Tgmobk0mZ8M595H46Lim_+z4a5vgRdSW-ppCk5sArTQ2ioWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Jul 29, 2024 at 12:40 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> I think it also provides the (valuable!) check that spinlocks were actually
> initialized. But that again seems like something we'd be better off adding
> more general infrastructure for - nobody runs --disable-spinlocks locally, we
> shouldn't need to run this on the buildfarm to find problems like this.
+1. It sucks to have to do special builds to catch a certain kind of
problem. I know I've been guilty of that (ahem, debug_parallel_query
f/k/a force_parallel_mode) but I'm not going to put it on my CV as one
of my great accomplishments. It's much better if we can find a way for
a standard 'make check-world' to tell us about as many things as
possible, so that we don't commit and then find out.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2024-07-29 17:38:41 | pgsql: Remove dead generators for cyrillic encoding conversion tables |
| Previous Message | Tom Lane | 2024-07-29 17:25:22 | Re: Detect double-release of spinlock |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2024-07-29 17:41:06 | Re: Remove dead code generation tools in src/backend/utils/mb/ |
| Previous Message | Tom Lane | 2024-07-29 17:25:22 | Re: Detect double-release of spinlock |