| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Emre Hasegeli <emre(at)hasegeli(dot)com>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve geometric types |
| Date: | 2017-09-14 20:19:13 |
| Message-ID: | CA+TgmobinBA7uvQifYaYGdDUoF6VTo56dvoTT6nKSpJF-Zfv5A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 14, 2017 at 3:33 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> I recall a bit about the double-evaluation hazards. I think the
> functions needs a comment describing the reasons so that anyone
> kind won't try to merge them into a macro again.
I think we can count on PostgreSQL developers to understand the
advantages of an inline function over a macro. Even if they don't,
the solution can't be to put a comment in every place where an inline
function is used explaining it. That would be very repetitive.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-09-14 20:59:06 | Re: Patches that don't apply or don't compile: 2017-09-12 |
| Previous Message | David G. Johnston | 2017-09-14 20:19:09 | Re: [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur |