| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Rui Zhao <xiyuan(dot)zr(at)alibaba-inc(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, hlinnaka <hlinnaka(at)iki(dot)fi>, tgl <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Detach shared memory in Postmaster child if not needed |
| Date: | 2024-07-29 18:10:27 |
| Message-ID: | CA+TgmobgW-hyqJwVO+J-Lf+o51Uw8ays1swoHz1Jtb4QX2S7=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 29, 2024 at 5:57 AM Rui Zhao <xiyuan(dot)zr(at)alibaba-inc(dot)com> wrote:
> Prior to PG16, postmaster children would manually detach from shared memory
> if it was not needed. However, this behavior was removed in fork mode in
> commit aafc05d.
Oh. The commit message makes no mention of that. I wonder whether it
was inadvertent.
> Detaching shared memory when it is no longer needed is beneficial, as
> postmaster children (like syslogger) don't wish to take any risk of
> accidentally corrupting shared memory. Additionally, any panic in these
> processes will not reset shared memory.
+1.
> The attached patch addresses this issue by detaching shared memory after
> fork_process().
I don't know whether this is the correct approach or not, but
hopefully Heikki can comment.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-07-29 18:12:19 | Re: Detect double-release of spinlock |
| Previous Message | Robert Haas | 2024-07-29 18:05:18 | Re: Interrupts vs signals |