| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Generalize ereport_startup_progress infrastructure |
| Date: | 2022-08-09 12:35:24 |
| Message-ID: | CA+Tgmobg5Hchwm9arFaJYWamOmuufT3R_KsGxuqdx1VPwXu8PA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 8, 2022 at 12:29 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> Here's v2 patch, passing progress report interval as an input to
> begin_progress_report_phase() so that the processes can use their own
> intervals(hard-coded or GUC) if they wish to not use the generic GUC
> log_progress_report_interval.
I don't think we should rename the GUC to be more generic. I like it
the way that it is.
I also think you should extend this patch series with 1 or 2
additional patches showing where else you think we should be using
this infrastructure.
If no such places exist, this is pointless.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-08-09 12:37:16 | Re: [RFC] building postgres with meson |
| Previous Message | Justin Pryzby | 2022-08-09 12:26:22 | Re: support for MERGE |