| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Васильев Дмитрий <d(dot)vasilyev(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Performance degradation in commit ac1d794 |
| Date: | 2016-02-11 17:18:30 |
| Message-ID: | CA+Tgmobft858D8YHOMAUDY31d5Li1wt6p0-MvYeTVwo0UkoBqA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 14, 2016 at 12:28 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> This brings me to something related: I'm wondering if we shouldn't merge
>> unix/win32_latch.c.
>
> Well, it's duplicated code on the one hand versus maze-of-ifdefs on the
> other. Feel free to try it and see, but I'm unsure it'd be an improvement.
I think we should either get this fixed RSN or revert the problematic
commit until we get it fixed. I'd be rather disappointed about the
latter because I think this was a very good thing on the merits, but
probably not good enough to justify taking the performance hit over
the long term.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-02-11 17:29:16 | pl/pgsql exported functions |
| Previous Message | Robert Haas | 2016-02-11 17:11:26 | Re: Re: [COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution. |