| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Explain [Analyze] produces parallel scan for select Into table statements. |
| Date: | 2016-03-10 16:09:13 |
| Message-ID: | CA+TgmobfabffE5EisZo3pXp96jGhpLeMa6VJvkviNBCneSHoxw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 10, 2016 at 4:43 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> There should be a white space between 0:CURSOR_OPT_PARALLEL_OK. Also I
> don't see this comment is required as similar other usage doesn't have any
> such comment. Fixed these two points in the attached patch.
>
> In general, the patch looks good to me and solves the problem mentioned. I
> have ran the regression tests with force_parallel_mode and doesn't see any
> problem.
I guess there must not be an occurrence of this pattern in the
regression tests, or previous force_parallel_mode testing would have
found this problem. Perhaps this patch should add one?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexey Grishchenko | 2016-03-10 16:20:10 | Re: Endless loop calling PL/Python set returning functions |
| Previous Message | Tom Lane | 2016-03-10 16:07:06 | Re: [PROPOSAL] Client Log Output Filtering |