Re: Abbreviated keys for Datum tuplesort (was: Re: B-Tree support function number 3 (strxfrm() optimization))

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Abbreviated keys for Datum tuplesort (was: Re: B-Tree support function number 3 (strxfrm() optimization))
Date: 2015-05-13 19:28:21
Message-ID: CA+TgmobeZRMi0tri8GLt0gc9dSsRwParX9xyZSjFKf0D0vQcxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 13, 2015 at 2:44 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Wed, May 13, 2015 at 11:40 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Committed. Thanks for the patch and your patience.
>
> This comment was not updated:
>
> /*
> * The sortKeys variable is used by every case other than the datum and
> * hash index cases; it is set by tuplesort_begin_xxx. tupDesc is only
> * used by the MinimalTuple and CLUSTER routines, though.
> */
> TupleDesc tupDesc;
> SortSupport sortKeys; /* array of length nKeys */

Oops. Fixed. Thanks.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-05-13 19:53:53 Re: Proposal : REINDEX xxx VERBOSE
Previous Message Alexander Korotkov 2015-05-13 19:17:54 Re: KNN-GiST with recheck