Re: custom variables and PGC_SUSET issue

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: custom variables and PGC_SUSET issue
Date: 2011-09-07 18:07:25
Message-ID: CA+TgmobeN1CkTij08dfc2OstQeG4mQ3X1Vj25wJn2vUUzZBDwQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 7, 2011 at 2:05 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Sep 7, 2011 at 1:55 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> You can't set a custom SUSET variable in advance of loading the module,
>>> because the system has no way to know it should enforce superuser
>>> restrictions on setting it. For the most part, this is a good reason to
>>> avoid custom SUSET variables.
>
>> Apparently we haven't taken that advice ourselves?
>
> The ones in auto_explain and pg_stat_statements aren't too problematic
> because those modules are designed to be preloaded by the postmaster.
> We've avoided adding such variables in modules that aren't intended
> to be used that way.

What about plpgsql.variable_conflict?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-09-07 18:12:34 Re: Large C files
Previous Message Tom Lane 2011-09-07 18:05:32 Re: custom variables and PGC_SUSET issue