| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thom Brown <thom(at)linux(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: B-Tree support function number 3 (strxfrm() optimization) |
| Date: | 2014-08-07 19:15:22 |
| Message-ID: | CA+TgmobdKhCBcTZ8m2B9Xq6WGPaBxviAa0FoUHVt-03gLJ7PQA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 6, 2014 at 7:18 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Wed, Aug 6, 2014 at 1:11 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I've committed the patch I posted yesterday. I did not see a good
>> reason to meld that together in a single commit with the first of the
>> patches you posted; I'll leave you to revise that patch to conform
>> with this approach.
>
> Okay. Attached is the same patch set, rebased on top on your commit
> with appropriate amendments.
Two things:
+ * result. Also, since strxfrm()/strcoll() require
NULL-terminated inputs,
In my original patch, I wrote NUL, as in the NUL character. You've
changed it to NULL, but the original was correct. NULL is a pointer
value that is not relevant here; the character with value 0 is NUL.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-08-07 19:17:50 | Re: B-Tree support function number 3 (strxfrm() optimization) |
| Previous Message | Peter Geoghegan | 2014-08-07 19:06:11 | Re: A worst case for qsort |