| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
| Date: | 2021-09-30 19:02:04 |
| Message-ID: | CA+Tgmob_sSSt-rowsp1ibgQuatUN38wyjD72GWjv5KXHb6-MCw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Sep 30, 2021 at 6:08 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> I think we can do better than using XLOG_INCLUDE_XID flag in the
> record being inserted. We need this flag so that we can mark
> SubTransaction assigned after XLogInsertRecord() is successful. We
> can instead output a flag (say sub_xact_assigned) from
> XLogRecordAssemble() and pass it to XLogInsertRecord(). Then in
> XLogInsertRecord(), we can mark SubTransactionAssigned once the record
> is inserted (after or before calling
> MarkCurrentTransactionIdLoggedIfAny()).
Isn't there other communication between these routines that just uses
global variables?
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-30 20:24:13 | pgsql: Remove gratuitous environment dependency in 002_types.pl test. |
| Previous Message | Tom Lane | 2021-09-30 18:16:18 | pgsql: Treat ETIMEDOUT as indicating a non-recoverable connection failu |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-30 19:10:25 | Re: when the startup process doesn't (logging startup delays) |
| Previous Message | Tom Lane | 2021-09-30 18:53:56 | Re: prevent immature WAL streaming |