From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
Subject: | Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly |
Date: | 2018-02-28 15:20:44 |
Message-ID: | CA+Tgmob_WGK+vKzE6FmrMmuwuv4myntfRAkEbo+tsDt9xUwCLQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Feb 27, 2018 at 5:14 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I ran the postgres_fdw regression test with no sleep two times in a
>> CLOBBER_CACHE_ALWAYS-enabled build, and then the regression test with
>> the sleep (60 seconds) two times, but I couldn't reproduce that in both
>> cases. I suspect the changes in the order of the RETURNING output there
>> was still caused by autovacuum kicking in partway through the run. So
>> to make the regression test more stable against autovacuum, I'd propose
>> to modify the regression test to disable autovacuum for the remote table
>> (ie "S 1"."T 1") (and perform VACUUM ANALYZE to that table manually
>> instead) in hopes of getting that fixed. Attached is a patch for that.
>> I think changes added by the previous patch wouldn't make sense
>> anymore, so I removed those changes.
>
> Ping? We're still seeing those failures on jaguarundi.
This is another patch that got past me. Committed now.
I'd be lying if I said I was filled with confidence that this was
going to fix it, but I don't know what to do other than keep tinkering
with it until we find something that works.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Alex Ignatov | 2018-02-28 15:23:04 | RE: Direct converting numeric types to bool |
Previous Message | Pavel Stehule | 2018-02-28 15:14:26 | Re: Direct converting numeric types to bool |