Re: Semantics of pg_file_settings view

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Semantics of pg_file_settings view
Date: 2015-06-26 20:07:46
Message-ID: CA+TgmobZpov+GWSzi5CNKgg34VK-pCJOwMXoPhP4Zp4h5tHhSA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 26, 2015 at 4:02 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Combining this with my idea about preserving the ConfigVariable list,
> I'm thinking that it would be a good idea for ProcessConfigFile() to
> run in a context created for the purpose of processing the config files,
> rather than blindly using the caller's context, which is likely to be
> a process-lifespan context and thus not a good place to leak in.
> We could keep this context around until the next SIGHUP event, so that
> the ConfigVariable list remains available, and then destroy it and
> replace it with the next ProcessConfigFile's instance of the context.
> In this way, any leakage in the processing code could not accumulate
> over multiple SIGHUPs, and so it would be certain to remain fairly
> negligible.

That seems like a nice idea.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2015-06-26 20:11:25 Re: git push hook to check for outdated timestamps
Previous Message Tom Lane 2015-06-26 20:02:15 Re: Semantics of pg_file_settings view