| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: custom function for converting human readable sizes to bytes |
| Date: | 2016-01-04 17:14:27 |
| Message-ID: | CA+TgmobYaDq=WdkpaQxM52wWncOPhKBQiaHHBg+kMfP0VnLRkg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 4, 2016 at 11:48 AM, Shulgin, Oleksandr
<oleksandr(dot)shulgin(at)zalando(dot)de> wrote:
> On Mon, Jan 4, 2016 at 4:51 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>
>> On Mon, Jan 4, 2016 at 10:17 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
>> wrote:
>> > [ new patch ]
>>
>> + case '-':
>> + ereport(ERROR,
>> + (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>> + errmsg("size cannot be negative")));
>>
>> Why not? I bet if you copy any - sign to the buffer, this will Just Work.
>
>
> I'm also inclined on dropping that explicit check for empty string below and
> let numeric_in() error out on that. Does this look OK, or can it confuse
> someone:
>
> postgres=# select pg_size_bytes('');
> ERROR: invalid input syntax for type numeric: ""
I think that's a pretty bad error message. I mean, the user is
calling a function that takes text as an input data type. So, where's
numeric involved?
I'm also kind of wondering what the intended use case for this
function is. Why do we want it? Do we want it?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-01-04 17:15:27 | Re: Some 9.5beta2 backend processes not terminating properly? |
| Previous Message | Shulgin, Oleksandr | 2016-01-04 17:13:59 | Re: custom function for converting human readable sizes to bytes |