| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: alternative to PG_CATCH |
| Date: | 2019-10-28 12:45:57 |
| Message-ID: | CA+TgmobXZv0mtTgyM0ivd1tiURuEefy0v2g25Owv8Vi3xJBGtg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 28, 2019 at 4:43 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> Here is a new implementation that works just like that.
This looks like a marked notational improvement.
With the patch:
[rhaas pgsql]$ git grep PG_CATCH | wc -l
102
[rhaas pgsql]$ git grep PG_FINALLY | wc -l
55
I'm actually a bit surprised that the percentage of cases that could
be converted to use PG_FINALLY wasn't even higher than that.
In theory, the do_rethrow variable could conflict with a symbol
declared in the surrounding scope, but that doesn't seem like it's a
problem worth getting worked up about.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surafel Temesgen | 2019-10-28 12:48:08 | Re: WIP: System Versioned Temporal Table |
| Previous Message | Robert Haas | 2019-10-28 12:37:48 | Re: Proposition to use '==' as synonym for 'IS NOT DISTINCT FROM' |