Re: updated emacs configuration

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: updated emacs configuration
Date: 2014-01-30 19:58:15
Message-ID: CA+TgmobXJmnF7f0WpTtH-3U_B2e4C1=XTwbBcn90HLptn=AXOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 29, 2014 at 11:21 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Wed, Jan 29, 2014 at 07:31:29PM -0500, Tom Lane wrote:
>> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> > I have cleaned up entab.c so I am ready to add a new option that removes
>> > tabs from only comments. Would you like me to create that and provide a
>> > diff at a URL? It would have to be run against all back branches.
>>
>> If you think you can actually tell the difference reliably in entab,
>> sure, give it a go.
>
> OK, I have modified entab.c in a private patch to only process text
> inside comments, and not process leading whitespace, patch attached. I
> basically ran 'entab -o -t4 -d' on the C files.
>
> The result are here, in context, plain, and unified format:
>
> http://momjian.us/expire/entab_comment.cdiff
> http://momjian.us/expire/entab_comment.pdiff
> http://momjian.us/expire/entab_comment.udiff
>
> and their line counts:
>
> 89741 entab_comment.cdiff
> 26351 entab_comment.pdiff
> 50503 entab_comment.udiff
>
> I compute 6627 lines as modified. What I did not do is handle _only_
> cases with periods before the tabs. Should I try that?

I don't have any comment on that specific point, but I took a quick
look through one of these diffs and it looks like a lot of churn for
no improvement. So I'm not sure what we want to do here, but I don't
think it's this.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2014-01-30 20:04:00 Re: updated emacs configuration
Previous Message Jim Nasby 2014-01-30 19:51:57 Re: Fwd: Request for error explaination || Adding a new integer in indextupleData Structure