Re: an outdated comment for hash_seq_init.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: an outdated comment for hash_seq_init.
Date: 2017-04-25 15:00:16
Message-ID: CA+TgmobU=F1JtGZ+bL91D7sE2+cBybmJ+WMQdmTT0cyV2dvO0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 24, 2017 at 3:55 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> While I looked into dynahash.c, I found that the following
> sentense became outdated by 5dfc198. The commit removed the only
> usage of hash_freeze().
>
>> * NOTE: it is possible to use hash_seq_init/hash_seq_search without any
>> * worry about hash_seq_term cleanup, if the hashtable is first locked against
>> * further insertions by calling hash_freeze. This is used by nodeAgg.c,
>> * wherein it is inconvenient to track whether a scan is still open, and
>> * there's no possibility of further insertions after readout has begun.
>
> The attached patch removes the sentence begins with "This is used
> by..".

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2017-04-25 15:00:42 Re: A note about debugging TAP failures
Previous Message Bruce Momjian 2017-04-25 14:58:44 Re: PG 10 release notes