Re: where should I stick that backup?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: where should I stick that backup?
Date: 2020-04-08 19:38:35
Message-ID: CA+TgmobTsO6ehqhqU7ggSVKDOX+ZD+5-6cSfDWRN88XFy8KB6A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 8, 2020 at 2:06 PM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> > On Wed, Apr 8, 2020 at 1:05 PM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > > What if %f.bz2 already exists?
> >
> > That cannot occur in the scenario I described.
>
> Of course it can.

Not really. The steps I described involved creating a new directory.
Yeah, in theory, somebody could inject a file into that directory
after we created it and before bzip writes any files into it, but
pg_basebackup already has the exact same race condition.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-04-08 19:41:30 Re: backup manifests and contemporaneous buildfarm failures
Previous Message Anna Akenteva 2020-04-08 19:36:28 Re: [HACKERS] make async slave to wait for lsn to be replayed