Re: Windows buildfarm animals are still not happy with abbreviated keys patch

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Windows buildfarm animals are still not happy with abbreviated keys patch
Date: 2015-01-22 20:34:27
Message-ID: CA+TgmobTKp5KmK2guXY5f63+xiLJr16iYnsxG-ipSE3p3+kckA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 22, 2015 at 1:00 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Thu, Jan 22, 2015 at 9:55 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Stay tuned for more exciting dispatches from the department of abbreviated keys!
>
> I certainly suspected that we'd have problems with Windows, but
> nothing this bad.

This isn't really Windows-specific. The root of the problem is that
when LC_COLLATE=C you were trying to use strxfrm() for the abbreviated
key even though memcmp() is the authoritative comparator in that case.
Exactly which platforms happened to blow up as a result of that is
kind of beside the point.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-01-22 20:34:48 Re: pg_upgrade and rsync
Previous Message Heikki Linnakangas 2015-01-22 20:19:18 Re: pg_upgrade and rsync