| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Jeff Davis <pgsql(at)j-davis(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Is this a problem in GenericXLogFinish()? |
| Date: | 2023-11-13 17:21:34 |
| Message-ID: | CA+TgmobSARYNQHvOHrehH-+YHkLGWdqJkuxrnDHCcviOYZ+Qgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 13, 2023 at 12:47 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> Moved.
I see that this patch was committed, but I'm not very convinced that
the approach is correct. The comment says this:
+ /*
+ * A write buffer needs to be registered even if no tuples are
+ * added to it to ensure that we can acquire a cleanup lock on it
+ * if it is the same as primary bucket buffer or update the
+ * nextblkno if it is same as the previous bucket buffer.
+ */
But surely if the buffer is the same as one of those others, then it's
registered anyway, and if it isn't, then it doesn't need to be.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2023-11-13 17:40:49 | Re: Official Windows Installer and Documentation |
| Previous Message | Bruce Momjian | 2023-11-13 17:14:57 | Re: pg_walfile_name_offset can return inconsistent values |