| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com> |
| Cc: | Andrey Borodin <amborodin86(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Amcheck verification of GiST and GIN |
| Date: | 2022-12-14 17:25:17 |
| Message-ID: | CA+TgmobQO_tJZGsDm7=z5e5xvoPRXoq9P+B+xThBA_ddET5rSg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 14, 2022 at 7:19 AM Jose Arthur Benetasso Villanova
<jose(dot)arthur(at)gmail(dot)com> wrote:
> I'm a bit lost here. I tried your patch again and indeed the
> heapallindexed inside gin_check_parent_keys_consistency has a TODO
> comment, but it's unclear to me if you are going to implement it or if the
> patch "needs review". Right now it's "Waiting on Author".
FWIW, I don't think there's a hard requirement that every index AM
needs to support the same set of amcheck options. Where it makes sense
and can be done in a reasonably straightforward manner, we should. But
sometimes that may not be the case, and that seems fine, too.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-12-14 17:34:35 | Re: fix and document CLUSTER privileges |
| Previous Message | Nathan Bossart | 2022-12-14 17:23:15 | Re: Rework confusing permissions for LOCK TABLE |