Re: pgsql: Don't send protocol messages to a shm_mq that no longer exists.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Don't send protocol messages to a shm_mq that no longer exists.
Date: 2015-10-16 13:52:42
Message-ID: CA+TgmobPbGJjGWvC9VcwiwhOMnpb_OgZxAxe9obkaE59Adgvrw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Oct 16, 2015 at 9:50 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> Don't send protocol messages to a shm_mq that no longer exists.
>
> Commit 2bd9e412f92bc6a68f3e8bcb18e04955cc35001d introduced a mechanism
> for relaying protocol messages from a background worker to another
> backend via a shm_mq. However, there was no provision for shutting
> down the communication channel. Therefore, a protocol message sent
> late in the shutdown sequence, such as a DEBUG message resulting from
> cranking up log_min_messages, could crash the server. To fix, install
> an on_dsm_detach callback that disables sending messages to the shm_mq
> when the associated DSM is detached.

And of course that should have set client_min_messages. Sigh.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-10-16 13:58:56 pgsql: Transfer current command counter ID to parallel workers.
Previous Message Robert Haas 2015-10-16 13:50:59 pgsql: Don't send protocol messages to a shm_mq that no longer exists.