Re: pgsql: Add 'basebackup_to_shell' contrib module.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: 2022-03-31 16:30:08
Message-ID: CA+TgmobO12W175z7MfPS1z=gQfJRzgC0vCtfb2PpgTgBqP-Cng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Mar 31, 2022 at 12:25 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Yeah, I think the fix is as simple as the attached.

Well, that does not work because you added an extra parenthesis which
makes Perl barf. If you fix that, then the test does not pass because,
as I just explained to Tom, the flag we call --create-role doesn't
create a role:

error running SQL: 'psql:<stdin>:1: ERROR: role "backupuser" does not exist'

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-03-31 16:45:13 Re: pgsql: Add 'basebackup_to_shell' contrib module.
Previous Message Andrew Dunstan 2022-03-31 16:25:38 Re: pgsql: Add 'basebackup_to_shell' contrib module.

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-03-31 16:34:41 Re: head fails to build on SLES 12 (wal_compression=zstd)
Previous Message Andres Freund 2022-03-31 16:28:44 Re: unlogged sequences