Re: bailing out in tap tests nearly always a bad idea

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bailing out in tap tests nearly always a bad idea
Date: 2022-02-14 17:47:44
Message-ID: CA+TgmobNofXrdsgujZNedyhO5=GNk_t6zfB4PMDUWnbS5e=FaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 13, 2022 at 6:33 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Huh, doesn't Test::More already provide a sane way to do this?
> If not, why isn't die() good enough? (I don't think you can
> realistically expect to prohibit die() anywhere in the TAP tests.)

+1 for die. There's very little reason to use BAIL_OUT. If we agree
that we need a wrapper for die() for some reason, I can live with
that, too, but die is simple and familiar to perl programmers.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-02-14 17:51:04 Re: fixing bookindex.html bloat
Previous Message Andres Freund 2022-02-14 17:46:20 Re: bailing out in tap tests nearly always a bad idea