Re: logical replication launcher crash on buildfarm

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: logical replication launcher crash on buildfarm
Date: 2017-03-31 13:42:31
Message-ID: CA+TgmobNi6++NFCQgSay4A05-FNVFfYVKxfBa00zke8vqU1V3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 28, 2017 at 7:39 PM, Petr Jelinek
<petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
> Sigh, forgot git add for the docs, so one more try...

+ if (strncmp(worker->bgw_library_name, "postgres", 8) != 0)
+ return NULL;

I think that's not right. You don't want to match postgresshdkgjsdglkjs.

Aside from that, these look good to me.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Michálek 2017-03-31 13:59:23 Re: Other formats in pset like markdown, rst, mediawiki
Previous Message Aleksander Alekseev 2017-03-31 13:40:07 Re: Multiple false-positive warnings from Valgrind