From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Geoghegan <pg(at)heroku(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Minor clarifying changes to abbreviated key abort code comments |
Date: | 2015-11-03 19:24:18 |
Message-ID: | CA+TgmobKwQEFuBYu4R5ShGM1au9Y56Rn4xb3h5=1ySiDJv0nEw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Nov 3, 2015 at 2:19 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Tue, Nov 3, 2015 at 11:15 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> OK, I see. Fixing comments in the back-branches is not always a
>> productive use of time, and in general I might like it if you pushed
>> for such things less frequently. But I've done it anyway in this
>> instance.
>
> I guess I favor doing it where the comment is actually wrong, which
> does apply here -- we don't *rely* on anything. We could very well
> abort when state is TSS_BUILDRUNS, but we elect not too, since
> TSS_BUILDRUNS is taken to mean that it's too late for aborting to be
> worth it.
Fair point.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-11-03 19:57:56 | Re: [PATCH] postgres_fdw extension support |
Previous Message | Peter Geoghegan | 2015-11-03 19:19:28 | Re: Minor clarifying changes to abbreviated key abort code comments |