From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | amul sul <sulamul(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Add hash partitioning. |
Date: | 2017-11-21 18:09:58 |
Message-ID: | CA+TgmobH1aEgmC9d6HSe8T-ev9L-GPBiMGq5+bEirszSzqK6xg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, Nov 20, 2017 at 7:46 AM, amul sul <sulamul(at)gmail(dot)com> wrote:
> Thanks for fixing this function. Patch looks good to me, except column number
> in the following errors message should to be 2.
>
> 354 +SELECT satisfies_hash_partition('mchash'::regclass, 2, 1,
> NULL::int, NULL::int);
> 355 +ERROR: column 1 of the partition key has type "text", but
> supplied value is of type "integer"
>
> Same at the line # 374 & 401 in the patch.
Oops. Looks like the indexing should be 1-based rather than 0-based.
Committed with that change.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-11-21 19:47:39 | pgsql: Provide for forward compatibility with future minor protocol ver |
Previous Message | Robert Haas | 2017-11-21 18:09:57 | pgsql: Fix multiple problems with satisfies_hash_partition. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-11-21 18:11:33 | Re: View with duplicate GROUP BY entries |
Previous Message | Robert Haas | 2017-11-21 17:55:52 | Re: feature request: consume asynchronous notification via a function |