| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavel Golub <pavel(at)gf(dot)microolap(dot)com>, Pavel Golub <pavel(at)microolap(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pavel Stěhule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: Fwd: Proposal: variant of regclass |
| Date: | 2014-04-08 14:34:04 |
| Message-ID: | CA+TgmobGiPgENjxiH5Wk+GKeHyiv2uqJGpO1ZQHHJr9tsq=cqg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 8, 2014 at 3:01 AM, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> On Mon, 7 Apr 2014 12:00:49 -0400
> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> In other words, let's revert the whole refactoring of this file to
>> create reg*_guts functions, and instead just copy the relevant logic
>> for the name lookups into the new functions. For to_regproc(), for
>> example, it would look like this (untested):
>>
>> names = stringToQualifiedNameList(pro_name_or_oid);
>> clist = FuncnameGetCandidates(names, -1, NIL, false, false, false);
>> if (clist == NULL || clist->next != NULL)
>> result = InvalidOid;
>> else
>> result = clist->oid;
>>
>> With that change, this patch will actually get a whole lot smaller,
>> change less already-existing code, and deliver cleaner behavior.
>
> Here is an updated patch. I rewrote regproc.c not to use _guts functions,
> and fixed to_reg* not accept a numeric OID. I also updated the documents
> and some comments. Is this better than the previous one?
Looks good, committed with a bit of further cleanup.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2014-04-08 14:35:22 | Re: WAL format and API changes (9.5) |
| Previous Message | Hadi Moshayedi | 2014-04-08 14:20:29 | Re: PostgreSQL Columnar Store for Analytic Workloads |