Re: pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu
Date: 2016-08-05 02:58:28
Message-ID: CA+TgmobB_gM57=aUfqqbkc4g+K3_pNAX+StJSn0nXZLH9LROjg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Aug 4, 2016 at 7:23 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>> Prevent "snapshot too old" from trying to return pruned TOAST tuples.
>
> Looks like this patch broke the build on castoroides. Recommend
> changing InitToastSnapshot into a macro. (There's a reason why
> InitDirtySnapshot is a macro.)

What is the reason? We refuse to separate frontend and backend
headers in any sort of principled way?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2016-08-05 03:10:35 pgsql: Fix hard to hit race condition in heapam's tuple locking code.
Previous Message Tom Lane 2016-08-04 23:23:26 Re: pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-08-05 03:16:13 Re: [sqlsmith] FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)", File: "xlog.c", Line: 10200)
Previous Message Claudio Freire 2016-08-05 02:53:05 Re: Heap WARM Tuples - Design Draft