| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactor heap_deform_tuple guts |
| Date: | 2013-08-07 00:54:52 |
| Message-ID: | CA+TgmobBXbz=yst6eB785Pt284T+oUaQBAZ+67LFjt7uhKuVoQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 6, 2013 at 6:32 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> heap_deform_tuple and slot_deform_tuple contain duplicated code. This
> patch refactors them so that the guts are in a single place.
>
> I have checked the resulting assembly code for heap_deform_tuple, and
> with the "inline" declaration, the gcc version I have (4.7.2) generates
> almost identical output both after the patch than before, thus there
> shouldn't be any slowdown.
Although I'm generally in favor of eliminating duplicated code, I have
to admit that in this case I'm not sure I see the point.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2013-08-07 01:24:47 | Re: Unsafe GUCs and ALTER SYSTEM WAS: Re: ALTER SYSTEM SET |
| Previous Message | David Fetter | 2013-08-07 00:27:13 | Re: Review: UNNEST (and other functions) WITH ORDINALITY |