From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Misleading panic message in backend/access/transam/xlog.c |
Date: | 2019-01-11 16:17:27 |
Message-ID: | CA+TgmobAaLT+C_+4HsACAceGC4nT=o4HD2QLoUo1Rj9fUDhatA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 9, 2019 at 8:38 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Jan 09, 2019 at 05:09:19PM -0800, Andres Freund wrote:
> > IIRC we have other such errors including offset and length (and if
> > not we'll grow some). It should be formatted as a genetic write
> > error with the file name, no reference to log file, etc, even if
> > there's no precedent.
>
> Yeah, there are a couple of them:
> access/transam/xlog.c:
> errmsg("could not read from log segment %s, offset %u: %m",
In smgr.c, we have:
"could not read block %u in file \"%s\": %m"
That seems to be the closet thing we have to a generic message
template right now, but it's not entirely generic because it talks
about blocks. Maybe we should go with something like:
"could not read %u bytes in file \"%s\" at offset %u: %m"
...and use that for both WAL and smgr.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2019-01-11 16:36:43 | Re: add_partial_path() may remove dominated path but still in use |
Previous Message | Robert Haas | 2019-01-11 16:12:25 | Re: Early WIP/PoC for inlining CTEs |