Re: a raft of parallelism-related bug fixes

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: a raft of parallelism-related bug fixes
Date: 2015-10-20 14:46:53
Message-ID: CA+Tgmob9gRNK0-2+HKDMKb486YnriVZqHaSt4faNoNjLoEzsEA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 17, 2015 at 6:17 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> It's good to have your perspective on how this can be improved, and
> I'm definitely willing to write more documentation. Any lack in that
> area is probably due to being too close to the subject area, having
> spent several years on parallelism in general, and 200+ emails on
> parallel sequential scan in particular. Your point about the lack of
> a good header file comment for execParallel.c is a good one, and I'll
> rectify that next week.

Here is a patch to add a hopefully-useful file header comment to
execParallel.c. I included one for nodeGather.c as well, which seems
to be contrary to previous practice, but actually it seems like
previous practice is not the greatest: surely it's not self-evident
what all of the executor nodes do.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
parallel-exec-header-comments.patch application/x-patch 2.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-10-20 14:50:39 Re: [PATCH] SQL function to report log message
Previous Message Robert Haas 2015-10-20 14:29:52 Re: Minor comment fix