From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: postgres_fdw vs. force_parallel_mode on ppc |
Date: | 2016-03-03 20:17:44 |
Message-ID: | CA+Tgmob8vtnRDBK3PVhPOun9+iqb6OOjUVfynGwmiSuFRpksHg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Mar 3, 2016 at 1:10 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
>> I've modified buildfarm member mandrill to use force_parallel_mode=regress and
>> max_parallel_degree=5; a full run passes. We'll now see if it intermittently
>> fails the stats test, like Tom witnessed:
>> http://www.postgresql.org/message-id/30385.1456077923@sss.pgh.pa.us
>
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mandrill&dt=2016-03-02%2023%3A34%3A10
A couple of my colleagues have been looking into this. It's not
entirely clear to me what's going on here yet, but it looks like the
stats get there if you wait long enough. Rahila Syed was able to
reproduce the problem and says that the attached patch fixes it. But
I don't quite understand why this should fix it.
BTW, this comment is obsolete:
-- force the rate-limiting logic in pgstat_report_tabstat() to time out
-- and send a message
SELECT pg_sleep(1.0);
pg_sleep
----------
(1 row)
That function was renamed in commit
93c701edc6c6f065cd25f77f63ab31aff085d6ac, but apparently Tom forgot to
grep for other uses of that identifier name.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
wait-for-trunc-stats.patch | application/x-download | 3.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-03-03 20:29:36 | Re: WIP: Upper planner pathification |
Previous Message | Mark Dilger | 2016-03-03 19:42:58 | Re: improving GROUP BY estimation |