| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> |
| Cc: | "Seki, Eiji" <seki(dot)eiji(at)jp(dot)fujitsu(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags |
| Date: | 2017-02-15 17:27:11 |
| Message-ID: | CA+Tgmob8Jf7LTkbAY1wetM0YUBjGwAjEwG2=AGYksfHUnS19pg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 14, 2017 at 1:38 PM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> wrote:
> On 2/14/17 3:13 AM, Seki, Eiji wrote:
>> +extern TransactionId GetOldestXmin(Relation rel, uint8 ignoreFlags);
>
>
> My impression is that most other places that do this sort of thing just call
> the argument 'flags', so as not to "lock in" a single idea of what the flags
> are for. I can't readily think of another use for flags in GetOldestXmin,
> but ISTM it's better to just go with "flags" instead of "ignoreFlags".
I agree; also, many years ago a guy named Tom Lane told me that flags
argument should typically be declared as type "int". I've followed
that advice ever since.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Janes | 2017-02-15 17:30:39 | Re: bytea_output vs make installcheck |
| Previous Message | Robert Haas | 2017-02-15 17:24:44 | Re: Should we cacheline align PGXACT? |