Re: Minor fix in reloptions.c comments

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Minor fix in reloptions.c comments
Date: 2019-04-15 17:47:16
Message-ID: CA+Tgmob5P5rVnJavME7SJq=ksbBRG7vydVA+QKccHZmik134bg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 12, 2019 at 12:01 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Apr 12, 2019 at 02:41:37AM +0000, Jamison, Kirk wrote:
> > I found some minor grammar mistake while reading reloptions.c code comments.
> > Attached is the fix.
> > I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
> > - * values has no affect until the ...
> > + * values has no effect until the ...
>
> A lot of those parameter updates affect processing and still they have
> many side effects, as per those paragraphs.

Well, "has no affect" is clearly wrong here, and Kirk's fix is clearly
right. I don't know what your point here is.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashwin Agrawal 2019-04-15 17:50:21 Re: Zedstore - compressed in-core columnar storage
Previous Message Tomas Vondra 2019-04-15 17:32:54 Re: Zedstore - compressed in-core columnar storage