Re: pgbench small bug fix

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench small bug fix
Date: 2016-03-08 22:03:31
Message-ID: CA+Tgmob5EFQVmhGBpMZoapjTvMeRb6u9YGh-TVw6ZGbGD0BgUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 27, 2016 at 2:31 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> - when a duration (-T) is specified, ensure that pgbench ends at that
> time (i.e. do not wait for a transaction beyond the end of the run).

Every other place where doCustom() returns false is implemented as
return clientDone(...). I think this should probably do the same.

I also think that we should probably store the end time someplace
instead of recomputing it in multiple places (this patch adds two such
places).

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-03-08 22:14:40 Re: extend pgbench expressions with functions
Previous Message Andres Freund 2016-03-08 21:49:43 Re: empty array case in plperl_ref_from_pg_array not handled correctly