| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> |
| Cc: | PgHacker <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [sepgsql 2/3] Add db_schema:search permission checks |
| Date: | 2013-04-03 16:43:14 |
| Message-ID: | CA+Tgmob2WttDsUY5TFC_aTmkYzERP099J91ihFwhoKhtHQx+jQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 2, 2013 at 2:22 PM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> OK, please check the attached ones.
Thanks. I reviewed the schema-search patch and I think it looks
reasonable, but shouldn't we be calling the event OAT_NAMESPACE_SEARCH
rather than OAT_SCHEMA_SEARCH? And, similarly,
ObjectAccessNamespaceSearch and InvokeNamespaceSearchHook? I think
this terminology could be confusing to backend hackers who are used to
seeing the term "namespace" internally when referring to schemas.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2013-04-03 16:45:44 | Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL) |
| Previous Message | David E. Wheeler | 2013-04-03 16:36:58 | Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL) |